Fix isChild check in CoberturaMultiSourceReader #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rolandtritsch, do you mind retrying the test job and reviewing the PR when you have time? I believe CI failed due to a flaky test on a sample project. |
|
Hi @ruippeixotog. Taking a look now ... |
rolandtritsch
approved these changes
Jul 9, 2023
|
Hi @ruippeixotog. Thank you for the fix/PR. Published a new release with the fix. - https://github.com/scoverage/sbt-coveralls/releases/tag/v1.3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
591ff35 changed
isChildto compare absolute paths rather than relative ones. However, it did something else - changed the variables being compared from instances ofPathtoStrings. WhilestartsWithis defined in both types, their behavior is not the same.Path#startsWithcorrectly determines if a path is a parent of another because it takes file path elements in consideration, whileString#startsWithdoes prefix checks at a character level.In real scenarios, this fails when using Scala version specific source folders like
src/main/scalaandsrc/main/scala-2.12, natively supported by SBT. They are sibling directories, but the current implementation incorrectly assumes them to be parent and children, respectively. On this PR we're fixing it by keeping usage of absolute paths while still usingPath.Added a unit test that correctly catches this error so that hopefully we don't get any regressions.