Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 3.3.4 around check to support excluded packages and filenames #561

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

a-morales
Copy link
Contributor

With the release of Scala 3.3.4 both coverageExcludedPackages and coverageExcludedFiles have been backported and should be supported now.

Copy link
Contributor

@jozic jozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ckipp01
Copy link
Member

ckipp01 commented Oct 7, 2024

It looks like there are some legit test failures. @a-morales can you look into it?

@a-morales
Copy link
Contributor Author

@ckipp01 I think I have resolved the test failures.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@ckipp01 ckipp01 merged commit 383f490 into scoverage:main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants