Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip compilation when skip scoverage to speed up build #178

Closed
wants to merge 2 commits into from
Closed

Skip compilation when skip scoverage to speed up build #178

wants to merge 2 commits into from

Conversation

justinplus
Copy link

@justinplus justinplus commented Dec 26, 2023 •
edited
Loading

Currently, when set skip as true in the configuration section of scoverage plugin, only testCompile and test are skipped for plugins like maven-compiler-plugin and scalatest-maven-plugin.

This PR set maven.main.skip as true in project property to skip compilation of main as well to speed up build.

jozic
jozic reviewed Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@jozic jozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @justinplus, thanks for your PR!
could you please add a simple integration test similar to those in it folder?
just something that will fail without your changes and pass with them
Thank you!

src/main/java/org/scoverage/plugin/SCoveragePreCompileMojo.java Outdated
@@ -212,6 +212,9 @@ public void execute() throws MojoExecutionException

Properties projectProperties = project.getProperties();

// for maven-compiler-plugin (compile), scala-maven-plugin (ompile)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be compile instead of ompile, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I would correct it

@justinplus
Copy link
Author

Hi @jozic, is there any guideline to add a new integration test?

@jozic
Copy link
Collaborator

jozic commented Dec 27, 2023

@justinplus
You can check existing tests in it directory and/or in PR #55

@jozic jozic self-requested a review December 27, 2023 03:21
@jozic jozic changed the base branch from master to main January 3, 2024 23:19
@jozic
Copy link
Collaborator

jozic commented Jan 5, 2024

Hey @justinplus, are you still interested in this PR?
no rush, just checking

@jozic
Copy link
Collaborator

jozic commented Jan 17, 2024

Hey @justinplus
i'm going to cut another release soon. Would you like to continue on this PR?

@justinplus
Copy link
Author

@jozic Sorry for the delay, I would continue on this PR.

@jozic jozic mentioned this pull request Nov 13, 2024
Merged
2 tasks
@jozic
Copy link
Collaborator

jozic commented Nov 15, 2024

Hey @justinplus
i've addressed this in #340, so closing this for now.
if you would like to change something else, please rebase and reopen or just create a new PR.
Thanks

@jozic jozic closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozic jozic Awaiting requested review from jozic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinplus @jozic