New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making RoomVisual an interface. #116

Open

r12f wants to merge 1 commit into screepers:master from r12f:master

r12f commented Aug 10, 2017

I found a helpful project to help us using RoomVisual in github, which is trying to extend the RoomVisual by changing its prototype: https://github.com/screepers/RoomVisual.

To make the project work for typescript, I created a typing to extend the RoomVisual: https://github.com/r12f/screeps-room-visual-extension-typings.

But since RoomVisual is declared as a class, typescript doesn't allow us to do it, so I am thinking to change this class to an interface.

I am very new in typescript, so please let me know, if it is actually a horrible idea.


          Making RoomVisual an interface.

2b29710

Contributor

thaelina commented Oct 3, 2017

Hey, change the constructor parameter to optional and this would be good. See #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet