Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all element listeners on remove resize #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove all element listeners on remove resize #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions detect-element-resize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
expandChild.style.height = expand.offsetHeight + 1 + 'px';
expand.scrollLeft = expand.scrollWidth;
expand.scrollTop = expand.scrollHeight;
};
}

function checkTriggers(element){
return element.offsetWidth != element.__resizeLast__.width ||
Expand All @@ -55,7 +55,7 @@
});
}
});
};
}

/* Detect CSS Animations support to detect element display/re-attach */
var animation = false,
Expand All @@ -71,11 +71,11 @@

if( animation === false ) {
for( var i = 0; i < domPrefixes.length; i++ ) {
if( elm.style[ domPrefixes[i] + 'AnimationName' ] !== undefined ) {
pfx = domPrefixes[ i ];
if( elm.style[ domPrefixes[i] + 'AnimationName'] !== undefined) {
pfx = domPrefixes[i];
animationstring = pfx + 'Animation';
keyframeprefix = '-' + pfx.toLowerCase() + '-';
animationstartevent = startEvents[ i ];
animationstartevent = startEvents[i];
animation = true;
break;
}
Expand Down Expand Up @@ -108,7 +108,7 @@
stylesCreated = true;
}
}
window.addResizeListener = function(element, fn){
if (attachEvent) element.attachEvent('onresize', fn);
else {
Expand All @@ -125,10 +125,15 @@
element.addEventListener('scroll', scrollListener, true);

/* Listen for a css animation to detect element display/re-attach */
animationstartevent && element.__resizeTriggers__.addEventListener(animationstartevent, function(e) {
if(e.animationName == animationName)
resetTriggers(element);
});
if (animationstartevent) {
element.__resizeTriggers__.animationStartListener = function (e) {
if (e.animationName == animationName) {
resetTriggers(element);
}
}

element.__resizeTriggers__.addEventListener(animationstartevent, element.__resizeTriggers__.animationStartListener);
}
}
element.__resizeListeners__.push(fn);
}
Expand All @@ -139,9 +144,12 @@
else {
element.__resizeListeners__.splice(element.__resizeListeners__.indexOf(fn), 1);
if (!element.__resizeListeners__.length) {
element.removeEventListener('scroll', scrollListener);
element.__resizeTriggers__ = !element.removeChild(element.__resizeTriggers__);
element.removeEventListener('scroll', scrollListener, true);
if (animationstartevent) {
element.__resizeTriggers__.removeEventListener(animationstartevent, element.__resizeTriggers__.animationStartListener);
}
element.__resizeTriggers__ = !element.removeChild(element.__resizeTriggers__);
}
}
}
};
})();
40 changes: 24 additions & 16 deletions jquery.resize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
else
addResizeListener(this, callback);
});
}
};

$.fn.removeResize = function(callback) {
return this.each(function() {
removeResizeListener(this, callback);
});
}
};

if (!attachEvent) {
var requestFrame = (function(){
Expand All @@ -52,7 +52,7 @@
expandChild.style.height = expand.offsetHeight + 1 + 'px';
expand.scrollLeft = expand.scrollWidth;
expand.scrollTop = expand.scrollHeight;
};
}

function checkTriggers(element){
return element.offsetWidth != element.__resizeLast__.width ||
Expand All @@ -72,7 +72,7 @@
});
}
});
};
}

/* Detect CSS Animations support to detect element display/re-attach */
var animation = false,
Expand All @@ -88,11 +88,11 @@

if( animation === false ) {
for( var i = 0; i < domPrefixes.length; i++ ) {
if( elm.style[ domPrefixes[i] + 'AnimationName' ] !== undefined ) {
pfx = domPrefixes[ i ];
if( elm.style[ domPrefixes[i] + 'AnimationName'] !== undefined) {
pfx = domPrefixes[i];
animationstring = pfx + 'Animation';
keyframeprefix = '-' + pfx.toLowerCase() + '-';
animationstartevent = startEvents[ i ];
animationstartevent = startEvents[i];
animation = true;
break;
}
Expand Down Expand Up @@ -125,7 +125,7 @@
stylesCreated = true;
}
}

window.addResizeListener = function(element, fn){
if (attachEvent) element.attachEvent('onresize', fn);
else {
Expand All @@ -140,12 +140,17 @@
element.appendChild(element.__resizeTriggers__);
resetTriggers(element);
element.addEventListener('scroll', scrollListener, true);

/* Listen for a css animation to detect element display/re-attach */
animationstartevent && element.__resizeTriggers__.addEventListener(animationstartevent, function(e) {
if(e.animationName == animationName)
resetTriggers(element);
});
if (animationstartevent) {
element.__resizeTriggers__.animationStartListener = function (e) {
if (e.animationName == animationName) {
resetTriggers(element);
}
}

element.__resizeTriggers__.addEventListener(animationstartevent, element.__resizeTriggers__.animationStartListener);
}
}
element.__resizeListeners__.push(fn);
}
Expand All @@ -156,9 +161,12 @@
else {
element.__resizeListeners__.splice(element.__resizeListeners__.indexOf(fn), 1);
if (!element.__resizeListeners__.length) {
element.removeEventListener('scroll', scrollListener);
element.__resizeTriggers__ = !element.removeChild(element.__resizeTriggers__);
element.removeEventListener('scroll', scrollListener, true);
if (animationstartevent) {
element.__resizeTriggers__.removeEventListener(animationstartevent, element.__resizeTriggers__.animationStartListener);
}
element.__resizeTriggers__ = !element.removeChild(element.__resizeTriggers__);
}
}
}
};
}( jQuery ));