Changed galaxyzoo.py for DR17 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgeron
requested review from
albireox,
bretthandrews and
havok2063
as code owners
havok2063
requested changes
Jul 15, 2021
There was a problem hiding this comment.
@tobiasgeron Can you remove the .DS_Store files, all the .pyc compiled files, every __pycache__ directory, and the sdss_marvin_.egg-info directory from the committed files? Those should all be ignored from the repo.
|
Alright, now all the unnecessary files should be removed. Thanks for pointing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
galaxyzoo.pyso that it works for DR17 and the new version of the VAC. The biggest difference is that there are three files now (gz_auto, gz_ukidss and gz). So Marvin will now return a dictionary with all the information of those three files for the relevant galaxy. The output for <DR17 will stay identical to before.