Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hi.py #742

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Update hi.py #742

merged 3 commits into from
Oct 8, 2021

Conversation

dvstark
Copy link
Contributor

@dvstark dvstark commented Sep 3, 2021

Fixes # Adds HI-MaNGA VAC functionality for DR17 by adding routine to select best spectrum between GBT vs. ALFALFA observations where necessary. Updates "version" entry with v2_0_1 for HI-MaNGA

This pull request:

  • Has a title that summarises what is changing.
  • Updates the documentation accordingly.
  • Has unit tests & code coverage is not adversely affected (within reason).
  • Works with Python 2.7 and 3.6 (and ideally with Python 3.7).
  • Updates the CHANGELOG.
  • Removes more lines of code than it adds.
  • If relevant, adds a new entry to the What's new? page.

@havok2063 havok2063 changed the base branch from master to vacs_dr17 September 22, 2021 17:23
Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is good. Once merged, I'll do some final checks and tests.

@havok2063 havok2063 merged commit 3ee7737 into sdss:vacs_dr17 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants