Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to Firefly VAC contribution #743

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

jusneuma
Copy link
Contributor

Fixes #

  • S/N and E(B-V) plots are now working
  • Includes the choice to select either the MILES or MaStar version of the FireflyVAC by using a callable dictionary.

ToDo: It works when I call cube.vacs.firefly, but it doesn't seem to work when I call VACs().firefly.

This pull request:

  • [x ] Has a title that summarises what is changing.
  • Updates the documentation accordingly.
  • Has unit tests & code coverage is not adversely affected (within reason).
  • Works with Python 2.7 and 3.6 (and ideally with Python 3.7).
  • Updates the CHANGELOG.
  • Removes more lines of code than it adds.
  • If relevant, adds a new entry to the What's new? page.

Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gave this a look through and made some comments/questions. In the meantime, I'll try to have a look at the code and see if I can diagnose why you're seeing the other error in the tools.VACs.

@havok2063 havok2063 merged commit 07f3cd0 into sdss:vacs_dr17 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants