Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GZ3D tutorial notebook #745

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

CKrawczyk
Copy link
Contributor

Karen has gone through and cleaned up some of the explanations and added a few links in places.

As part of this update we also fixed a bug in the polar_plot code where labels were not being used in the scatter plot calls. The examples in the notebook now explicitly create figure legends to ensure this is working as expected.

Fixes #

This pull request:

  • Has a title that summarises what is changing.
  • Updates the documentation accordingly.
  • Has unit tests & code coverage is not adversely affected (within reason).
  • Works with Python 2.7 and 3.6 (and ideally with Python 3.7).
  • Updates the CHANGELOG.
  • Removes more lines of code than it adds.
  • If relevant, adds a new entry to the What's new? page.

Karen has gone through and cleaned up some of the explanations and added a few links in places.

As part of this update we also fixed a bug in the `polar_plot` code where labels were not being used in the scatter plot calls.  The examples in the notebook now explicitly create figure legends to ensure this is working as expected.
@CKrawczyk
Copy link
Contributor Author

@havok2063 Just some minor updates to the GZ3D code, ready to merge once reviewed.

Added a reference link for azimuthal angle.
Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@havok2063 havok2063 merged commit 0b8ea0f into sdss:vacs_dr17 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants