More fixes for VACs #756
Merged
More fixes for VACs #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the Visual Morphology VAC from Marvin for DR17. Additionally, it adds the ability to use the
VACs.check_targetor an individual VAChas_targetmethods in a "low-memory" mode. In this mode, it accesses the individual FITS data extension as a context manager and deletes the HDU from memory immediately afterwards. This is useful when needing to open a large VAC file in a low-memory environment, e.g. by a web server.Since I'm not quite comfortable with the IO involved in opening ~6 VAC files for every hit of the galaxy web page, I'm hiding the web display of the VAC "is target available" check until a better solution can be implemented.
It also updates the pinned version of some of Marvin's dependencies.
It also bumps the memory of the web application.