-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Remove blacklist and make whitelist mandatory #385
Comments
👍 I would like this. The first thing I do in any new |
👍 for this. I always use a whitelist anyway. This is even more likely in the age of composer: if you don't define a whitelist, the code coverage will include anything from your |
👍 |
1 similar comment
👍 |
👍 I always use whitelist and never use blacklist |
+1 Black & Whitelist do not serve the purpose of clean code. |
+1 |
1 similar comment
👍 |
PHPUnit 5.0 has been changed: sebastianbergmann/phpunit@0fd7f2c The respective functionality will be removed from PHP_CodeCoverage 3.0 in time for the PHPUnit 5.0 release. |
Triggered by #384, I started thinking about how complex (and perceived by many users as complicated) the blacklist and whitelist functionality of PHPUnit and PHP_CodeCoverage is.
A radical approach to make this simpler, both for those working on PHP_CodeCoverage and those that use PHPUnit, could be to remove the blacklist and make the whitelist mandatory. Current versions of PHPUnit already emit a warning when code coverage is activated but no whitelist is configured.
Thoughts?
The text was updated successfully, but these errors were encountered: