Feature/branch coverage

[Maks3w]

This PR continue the work @sebastianbergmann made on feature/path-coverage branch.

Includes PRs #398 and #399

Close #380

TODO:

• Clover XML Report. I won't add support for cond line types.

[sebastianbergmann]

Thank you, @Maks3w, for this contribution. It will take a while for me to review this as I am very busy at the moment.

[Maks3w]

This PR is finish and ready for review. I suggest start for #398 and #399 for make the changeset more tiny.

[sebastianbergmann]

Yes, of course, I will look at #398 and #399 first. In the meantime it would help me (and others) if you could attach screenshots (maybe from the https://github.com/sebastianbergmann/money/ project) to this issue. Thanks!

[Maks3w]

These commits show the differences in the output respect master.

Maks3w@482cb3f
Maks3w@5e87574
Maks3w@4bc19d0
Maks3w@91387b8

Basically I've added the Path data close to the line statistics.

Now I'm playing with executing this in a real library project and I try to make it work. Seems does not recognize the paths but I don't know yet why.

[sebastianbergmann]

Ah, okay. So for now it's "only" textual. Still a good starting point. Do you also want to implement something like http://derickrethans.nl/images/content/paths-covered-mockup.png?

[Maks3w]

No sorry, too much. I'm trying to use this data for colorize paths in coveralls.io (using coverage 0/1 value instead hits per line)

[Maks3w]

I've found a bug related to namespaces. I'll fix it later.

[Maks3w]

Now works.

@derickr Any chance for add a whitelist coverage feature to XDebug? I think will save lots of memory because it now tracks all the PHPUnit framework stuff.

[sebastianbergmann]

@Maks3w http://bugs.xdebug.org/view.php?id=1144 is about pushing the filtering from PHPUnit down to Xdebug.

[sebastianbergmann]

Path coverage is always shown as 0% for me:

[Maks3w]

@sebastianbergmann Fixed

[Maks3w]

About the HTML Mockup I suggest to do the same I expect to do with coveralls. Turn green or red each line if is covered by a branch or not.

Some tests have too many paths > 4096 which is impossible to print.

[Maks3w]

@sebastianbergmann I've restored the compatibility with Xdebug < 2.3.2. However I suggest force pathCoverage param from PHPUnit

[sebastianbergmann]

Please rebase against current master, thanks.

[sebastianbergmann]

BTW: Thank you for your contributions. I am happy that somebody else works on this code :-) I would be even happier if you would configure your Git client to properly store your name and email with your commits (see https://github.com/sebastianbergmann/phpunit/blob/master/CONTRIBUTING.md#workflow).

Keep up the good work!

[Maks3w]

Rebased.

I don't understand what do you refer with configure my author data on Git. All my commits have a name and email.

[Maks3w]

Something is broken. Tests pass but resume is wrong.

[sebastianbergmann]

Maks3w <[email protected]> is what my Git client shows for your commits. I doubt that "Maks3w" is your real name :-) But no worries.

[Maks3w]

@sebastianbergmann Done. Was a problem while skipping path coverage if xdebug didn't support

[sebastianbergmann]

Re: #400 (comment)

Sure, PHPUnit will need a new configuration option (off by default, IMHO) to control path coverage.

[Maks3w]

No, Maks3w it's not my real name and my skin is not yellow :-)

[Maks3w]

I've open sebastianbergmann/phpunit#1937 about path coverage switch on PHPUnit configuration

[Maks3w]

Reopen as sebastianbergmann/phpunit#1938

[sebastianbergmann]

• The test suite for PHP_CodeCoverage itself fails when path coverage is disabled
• The HTML report must not have path coverage related columns etc. when path coverage is disabled

[Maks3w]

I know. I just did the lowest effort so the library still functional.

Do you think is needed to test both scenarios? (path on/off)

[Maks3w]

Exclude the path information in the HTML output will require duplicate the templates or develop a conditional statement the template.

Will also require duplicate all the test fixtures.

I think 0/0 could be a valid value as has been always in the Clover report (conditionals="0" coveredconditionals="0")

Probably the only thing we could do is paint the values (text and html outputs) with a disabled color (gray)

[Maks3w]

I've rewritten the bc commit. Loops are enough safe for to not depend of the pathCoverage setting value.

[Maks3w]

Tested with Xdebug 2.4.0beta1

[derickr]

How is this coming along?

[derickr]

poke?

[sebastianbergmann]

Closing #400 and #425 because they have run out-of-sync with master. Please coordinate, @Maks3w and @posey2010, and send a new pull request. Thanks!

[Maks3w]

@sebastianbergmann I won't spent more time on this for nothing. This PR has been open for 4 months. If you won't merge it why open a new PR

[sebastianbergmann]

I did not merge it because there were "competing" / conflicting merge requests and I got confused. I hope that a new pull request will be less confusing. Sorry :-(

[elynnaie]

Please don't give up on this! Having branch and path coverage would be extraordinarily helpful!