Speedup #433
Speedup #433
Conversation
- Init data by running xdebug with 'unused' and 'dead code' flags on all whitelist files - Run xdebug without flags for each test method - Cache num lines check for each file, to prevent superflous checks - (SB) Fix CS/WS issues
| @@ -39,7 +39,7 @@ | |||
| /** | |||
| * Start collection of code coverage information. | |||
| */ | |||
| public function start(); | |||
| public function start($determineUnusedAndDead = true); | |||
There was a problem hiding this comment.
you forgot to update the phpdoc
There was a problem hiding this comment.
Good point, I've added these now
|
This is a major breaking change due to the modification of an interface. Existing implementations will cause php to fatal error. |
|
Oh, I see the master is 4.x. That's fine then. ;) |
|
Thanks, @MajorCaiger. Did you do a benchmark and can share some numbers? |
|
The original benchmarks can be found here #384 I think the implementation changed slightly but the improvements should be similar. |
|
Hi @sebastianbergmann Thanks, |
|
There will be no major changes to anything related to PHPUnit 4.8, sorry. |
|
Unfortunate, but understandable :) |
|
This is already in PHPUnit 5.x is it not? |
|
We've seen a speed increase from 1h48m to 13m. I just want to say I really appreciate this change. |
|
@willemstuursma That's a fantastic improvement! |
Re-submitted after resolving conflicts as requested.