Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct missing highlighting of dead code #751

Merged

Conversation

dvdoug
Copy link
Contributor

@dvdoug dvdoug commented May 18, 2020

Hello @sebastianbergmann

I've noticed that dead code detection does not seem to be working correctly in the HTML report: the legend indicates that it should be highlighted in yellow but it currently outputs in white.

The HTML itself is correct, just needs a small tweak to the CSS.

Before
image

After
image

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #751   +/-   ##
=========================================
  Coverage     83.87%   83.87%           
  Complexity      846      846           
=========================================
  Files            37       37           
  Lines          2480     2480           
=========================================
  Hits           2080     2080           
  Misses          400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e16f3...7e66937. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit f0d58f7 into sebastianbergmann:master May 19, 2020
@dvdoug dvdoug deleted the fix_dead_code_highlight branch May 19, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants