Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up how uncovered files are handled #756

Merged

Conversation

dvdoug
Copy link
Contributor

@dvdoug dvdoug commented May 25, 2020

During the initial pass of whitelisted files in initializeData(), a processing step is undertaken on the collected coverage data to mark any executed code as non-executed since UNCOVERED_FILES_FROM_WHITELIST is not a real testcase id.

This can be simplified by simply not recording UNCOVERED_FILES_FROM_WHITELIST as a testcase id at all.

Doing this also means that the fake UNCOVERED_FILES_FROM_WHITELIST id can be kept internal to the CodeCoverage class and this implementation detail does not leak to the outside.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #756 into master will increase coverage by 0.25%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #756      +/-   ##
============================================
+ Coverage     84.32%   84.57%   +0.25%     
+ Complexity      877      872       -5     
============================================
  Files            38       38              
  Lines          2564     2554      -10     
============================================
- Hits           2162     2160       -2     
+ Misses          402      394       -8     
Impacted Files Coverage Δ Complexity Δ
src/Report/Xml/Facade.php 95.16% <ø> (+0.71%) 28.00 <0.00> (-1.00) ⬆️
src/CodeCoverage.php 69.66% <71.42%> (+1.34%) 157.00 <0.00> (-4.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca5b04...0203fc2. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 9a05d1f into sebastianbergmann:master May 26, 2020
@dvdoug dvdoug deleted the tidy_up_uncovered_files branch May 26, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants