Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @codeCoverageIgnore annotations work on branch/path coverage #758

Merged

Conversation

dvdoug
Copy link
Contributor

@dvdoug dvdoug commented May 27, 2020

Hello @sebastianbergmann

Following on from #757, this PR allows lines of code to be ignored inside branch and path coverage.

Each branch contains the details of it's starting and ending lines in it's data, and these are compared against the lines that should be ignored. If a match is found, the details of the branch and any paths that the branch is part of are removed from the coverage data.

This should be the final stage of the plumbing work for #380 before work can start on the actual reports.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #758 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #758      +/-   ##
============================================
+ Coverage     84.45%   84.51%   +0.06%     
- Complexity      881      888       +7     
============================================
  Files            40       40              
  Lines          2566     2576      +10     
============================================
+ Hits           2167     2177      +10     
  Misses          399      399              
Impacted Files Coverage Δ Complexity Δ
src/RawCodeCoverageData.php 98.90% <100.00%> (+0.13%) 51.00 <0.00> (+7.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d522289...fccc2c9. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 0dddde6 into sebastianbergmann:master May 28, 2020
@dvdoug dvdoug deleted the ignore_annotations branch May 28, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants