Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @covers annotations work on branch/path coverage #760

Merged

Conversation

dvdoug
Copy link
Contributor

@dvdoug dvdoug commented May 28, 2020

Hello @sebastianbergmann

Apologies, I was wrong, there is one additional plumbing piece required for #380 that I'd forgotten about, which is respecting @Covers annotations. Please see the attached PR.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #760 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
+ Coverage     84.51%   84.55%   +0.04%     
- Complexity      888      894       +6     
============================================
  Files            40       40              
  Lines          2576     2584       +8     
============================================
+ Hits           2177     2185       +8     
  Misses          399      399              
Impacted Files Coverage Δ Complexity Δ
src/RawCodeCoverageData.php 98.98% <100.00%> (+0.08%) 57.00 <0.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe4a52...fc91bab. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit d2ad210 into sebastianbergmann:master May 29, 2020
@dvdoug dvdoug deleted the covers_annotations branch May 29, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants