Empty lines not executable v2

[dvdoug]

#799, version 2

This version moves the skip logic from the very end of the process to the very beginning 🤞 that should cover all potential scenarios. This has been tested on #799 (no line 14) and sebastian/code-unit (no risky tests).

This is using a static array cache rather than the static analysis file cache because the file cache is predicated around filenames and methods, but the problem in #799 is lines that are completely outside of a method so those cache keys don't fit the usecase. The analysis itself is also fairly cheap so there's less benefit from persisting that across runs than the more advanced PHP-Parser based analyses so I think that should be OK.

[codecov]

Codecov Report

Merging #807 into master will increase coverage by 0.02%.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##             master     #807      +/-   ##
============================================
+ Coverage     83.29%   83.31%   +0.02%     
- Complexity     1124     1129       +5     
============================================
  Files            60       60              
  Lines          3471     3482      +11     
============================================
+ Hits           2891     2901      +10     
- Misses          580      581       +1     

Impacted Files	Coverage Δ	Complexity Δ
src/CodeCoverage.php	44.68% <44.44%> (-1.12%)	96.00 <3.00> (-3.00)
src/RawCodeCoverageData.php	96.20% <100.00%> (+0.81%)	38.00 <8.00> (+8.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889f1cc...745be79. Read the comment docs.

[sebastianbergmann]

Thanks!