[TEST] Add an end-to-end test #137
Conversation
spec/segment/analytics/e2e_spec.rb
Outdated
| # to receive the data sent by this library. | ||
| describe 'End-to-end tests', e2e: true do | ||
| WRITE_KEY = 'qhdMksLsQTi9MES3CHyzsWRRt4ub5VM6' | ||
| RUNSCOPE_BUCKET_KEY = 'pwb8mcmfks0f' |
There was a problem hiding this comment.
Can you add a comment mentioning this bucket can be viewed at https://www.runscope.com/stream/umkvkgv7ndby
There was a problem hiding this comment.
(umkvkgv7ndby and not pwb8mcmfks0f - sorry about the mixup!)
spec/segment/analytics/e2e_spec.rb
Outdated
| # webhook connected to the source (configured manually via the app) is able | ||
| # to receive the data sent by this library. | ||
| describe 'End-to-end tests', e2e: true do | ||
| WRITE_KEY = 'qhdMksLsQTi9MES3CHyzsWRRt4ub5VM6' |
There was a problem hiding this comment.
Could you add a comment that this writeKey corresponds to https://app.segment.com/segment-libraries/sources/analytics_ruby_e2e_test/overview
| @@ -4,6 +4,7 @@ default_tasks = [] | |||
|
|
|||
| RSpec::Core::RakeTask.new(:spec) do |spec| | |||
| spec.pattern = 'spec/**/*_spec.rb' | |||
| spec.rspec_opts = "--tag ~e2e" if ENV["RUN_E2E_TESTS"] != "true" | |||
There was a problem hiding this comment.
We should move this to Travis (like the runscope token). I believe non-owners won't be able to get the Runscope token anyway.
There was a problem hiding this comment.
I've added RUN_E2E_TESTS as a variable in travis https://cloudup.com/cmDLAS18POA
There was a problem hiding this comment.
I placed this check here to ensure that bundle exec rake works on a local system without hitting the network - less friction for an external contributor trying to run tests on their machine.
I believe non-owners won't be able to get the Runscope token anyway.
Ah, you're right - I've changed this to only run the end-to-end tests if travis secure env vars are present (master builds, or PRs from owners). 6b2983c
rohitpaulk
force-pushed
the
add-e2e-tests
branch
from
68a7ad8 to
380d59d
Compare
rohitpaulk
force-pushed
the
add-e2e-tests
branch
from
6b2983c to
60025f3
Compare
.travis.yml
Outdated
| @@ -14,3 +11,10 @@ rvm: | |||
|
|
|||
| before_install: | |||
| - gem install bundler | |||
|
|
|||
| script: | |||
| - if [ "$TRAVIS_SECURE_ENV_VARS" != "false" ]; then | |||
There was a problem hiding this comment.
@f2prateek For this to work, we'll have to remove the RUN_E2E_TESTS variable added to travis.
Either that, or we set both RUN_E2E_TESTS and RUNSCOPE_TOKEN as encypted variables and remove this check.
There was a problem hiding this comment.
I can update the RUN_E2E_TESTS to be encrypted. That seems easiest - also makes it easy to run the tests locally when needed.
There was a problem hiding this comment.
Cool, I'll remove the check then
There was a problem hiding this comment.
Added RUN_E2E_TESTS as an encrypted variable now.
rohitpaulk
force-pushed
the
add-e2e-tests
branch
from
60025f3 to
b75e488
Compare
|
Code updated. The E2E test should not be triggered in this PR, as it is from my fork. I've opened #139 to actually run the E2E test. Will close this as soon as the tests pass. |
Based on segmentio/analytics-node#134.
The
RUNSCOPE_TOKENenv var has to be added for this to work, tests will fail until that is done. Here's an example of passing tests on my fork: rohitpaulk#10