Create http client once per user request #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HttpResponse hubResponse = client.execute(post(target, message)); | ||
| JsonMessage hubMessage = JsonMessageFactory.from(hubResponse.getEntity().getContent()); | ||
|
|
||
| if (hubResponse.getStatusLine().getStatusCode() == SC_OK) { |
There was a problem hiding this comment.
Refactor this code to not nest more than 3 if/for/while/switch/try statements. 
|
SonarQube analysis reported 1 issue:
Watch the comments in this conversation to review them. |
innokenty
added a commit
that referenced
this pull request
Nov 17, 2015
create http client once per user request
innokenty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create http client once per user request for a new session instead of creating a new client per each hub attempt. In the scenario when the grid is fully loaded which results in lots of reattemps that change drastically reduces the amount of clients created and therefore increases performance.