-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sequelize bin support options file + migration path #1540
Conversation
migrationsPath configured via cli loading all cli switches via json configuration file , loaded via --options
Whats the reason for this exactly? |
There are two changes intertwined in this commit, sorry about that
added tests to test/sequelize.executable.test.js d. ................................................................. On Sun, Mar 23, 2014 at 9:48 AM, Mick Hansen [email protected]:
|
@@ -0,0 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move this file to test/config instead.
I'm not overly familiar with migrations, @sequelize/owners? |
I like the idea! Can you please move the options file for the tests and add support for setting the path to the options file via environment variable as well? Probably
|
.option('-U, --url <url>', 'Database url. An alternative to a config file') | ||
.option('-o,--cli-options <options_file>', 'Specifies lib options from file.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for
'-o, --options-path <options-path>' ...
I renamed the options from |
migrationsPath configuration enabled via cli
loading all cli switches via json configuration file (via --options)