Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify some statements for readability #1007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hamirmahal
Copy link

Closes #1006

Verified

This commit was signed with the committer’s verified signature.
hamirmahal Hamir Mahal

Verified

This commit was signed with the committer’s verified signature.
hamirmahal Hamir Mahal
Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't result in any user-facing changes.

The goal here is to improve code readability and maintainability.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Luca Casonato <[email protected]>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@79ff014). Learn more about missing BASE report.

Files with missing lines Patch % Lines
url/tests/wpt.rs 50.00% 7 Missing ⚠️
url/src/lib.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage        ?   80.26%           
=======================================
  Files           ?       24           
  Lines           ?     4271           
  Branches        ?        0           
=======================================
  Hits            ?     3428           
  Misses          ?      843           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamirmahal
Copy link
Author

@lucacasonato are there any changes you'd like me to make here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some statements can be simplified for readability and developer productivity
2 participants