This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Add appveyor support for servo's homu #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me after SHA bump |
|
@bors-servo r=larsbergstrom |
|
📌 Commit 5be1c80 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
|
💔 Test failed - travis |
|
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
|
💔 Test failed - travis |
|
Google has dropped support for 32-bit Chrome (planned for March hence the sudden breakage): http://www.omgubuntu.co.uk/2016/03/fix-failed-to-fetch-google-chrome-apt-error-ubuntu Is there any reason we need Chrome? If not, I'd rather remove it entirely than trying to modify the appropriate |
|
We don't explicitly mention Chrome anywhere. I don't know why it tries to download chrome. |
|
I checked via Salt on the builders and you're right, none of our machines have chrome in their apt sources. |
|
Yup, looks ok in Vagrant. I'll put in a test PR to check Travis. |
|
See #233 for the Travis test PR |
aneeshusa
added a commit
to aneeshusa/servo-saltfs
that referenced
this pull request
Mar 5, 2016
Workaround saltstack/salt#26605 by cleaning the sources.list.d folder first, and running pkgrepo states that add repositories to the folder afterwards using require. This unbreaks servo#232: Travis has the Chrome apt repo configured, but Google has dropped 32-bit support (March 2016), causing apt to fail on multiarch hosts. By removing all external repos we will only use repositories we configure ourselves.
bors-servo
pushed a commit
that referenced
this pull request
Mar 5, 2016
Remove non-Salted external apt sources Workaround saltstack/salt#26605 by cleaning the sources.list.d folder first, and running pkgrepo states that add repositories to the folder afterwards using require. This unbreaks #232: Travis has the Chrome apt repo configured, but Google has dropped 32-bit support (March 2016), causing apt to fail on multiarch hosts. By removing all external repos we will only use repositories we configure ourselves. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/234) <!-- Reviewable:end -->
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA
r? @larsbergstrom