feat: add i18n support #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <[email protected]>
github-actions
bot
added
dependency
✅ Deploy Preview for atlassify canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 39 out of 44 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- src/renderer/i18n/locales/de.json: Language not supported
Comments suppressed due to low confidence (1)
src/renderer/components/settings/AppearanceSettings.tsx:106
- [nitpick] The onChange callback parameter 'option' is untyped, which might lead to unclear intent or potential issues with type inference. Consider explicitly typing this parameter (for example, as OptionType from '@atlaskit/select') for better clarity and type safety.
onChange={(option) => {
Signed-off-by: Adam Setch <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds internationalization (i18n) support to the application by replacing hard coded text labels with calls to the translation function. Key changes include:
- Adding a default language and updating appearance settings to include the language.
- Replacing static labels in various components (settings, sidebar, notifications) with i18n keys.
- Integrating the useTranslation hook into multiple components for dynamic language support.
Reviewed Changes
Copilot reviewed 42 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/context/App.tsx | Added default language support in appearance settings. |
| src/renderer/components/settings/* | Updated string literals to translation function calls. |
| src/renderer/components/notifications/* | Updated notification content labels with translation keys. |
| src/renderer/components/Sidebar.tsx | Replaced tooltip and button labels with i18n keys. |
| src/renderer/mocks/state-mocks.ts | Updated the default language in mock settings. |
Files not reviewed (7)
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- src/renderer/components/filters/snapshots/FilterSection.test.tsx.snap: Language not supported
- src/renderer/components/notifications/snapshots/AccountNotifications.test.tsx.snap: Language not supported
- src/renderer/components/notifications/snapshots/NotificationRow.test.tsx.snap: Language not supported
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add i18n internationalization support.
Current languages translated include German, French and Spanish by Google Translate via the a18n ally vscode extension