This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Fix IGuestSession.execute() on Python 3 where stdout and stderr are of type MemoryView #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... where stdout and stderr are of type `memoryview` and `str(memoryview)` turns to `'<memory 0x012345ABCDEF...>'`.
sethmlarson
changed the title
|
Fantastic! I haven't made the complete move to py3 yet, when I added the original py3 support vboxapi was not yet available for py3. I'm super happy that you're giving it a workout! |
|
I'm definitely giving it a workout. It's the most important dependency in this project. All Python versions and all platforms. Will continue to report all of the bugs I find upstream. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in Python 3 when running
IGuestSession.execute()you receive'<memory [address]>'because theexecute()function converts the memory view into a literalstrrather than the properbytes(same asstron Python 3). This fixes that behavior.