fix(sidebar): show close button to keyboard and screen reader users #6798
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@6TELOIV is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Jacksonmills
approved these changes
Feb 28, 2025
|
To test this change, view one of the sidebar blocks on a mobile size browser window, and open it with the keyboard. The button should show up focused, hide when you tab off of it, and show again when you return focus (shift-tab or tab all the way thru the sidebar). For non-keyboard non-screenreader users, this change should have no effect (the use of :focus-visible only shows it on keyboard navigation) Here's a screenshot demonstrating the change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6761
I noticed that on the default variant (as opposed to new-york) of the sidebar, it was missing the SidebarTitle import, so I added that as well.