Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(www): fix combobox-form code example, pass value instead of label as prop #6884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedrostanzani
Copy link

Modifies the "combobox-form" code example: https://ui.shadcn.com/docs/components/combobox#form

In the current code example, language.label gets passed down as a prop to the CommandItem component.

  {languages.map((language) => (
    <CommandItem
      value={language.label}  // <--- here
      key={language.value}
      onSelect={() => {
        form.setValue("language", language.value)
      }}
    >
    // ...

This PR modifies this snippet so that it passes language.value as a prop instead:

  {languages.map((language) => (
    <CommandItem
      value={language.value}  // <--- here
      key={language.value}
      onSelect={() => {
        form.setValue("language", language.value)
      }}
    >
    // ...

Copy link

vercel bot commented Mar 7, 2025

@pedrostanzani is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant