Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-angular-version-to-19 #2566

Merged

Conversation

akhromets
Copy link
Contributor

No description provided.

@akhromets akhromets force-pushed the bump-angular-version-to-19 branch from 498a3e7 to 92de159 Compare December 30, 2024 14:13
@akhromets akhromets force-pushed the bump-angular-version-to-19 branch from 92de159 to 987d00e Compare December 30, 2024 14:14
@dorpeled
Copy link

dorpeled commented Jan 6, 2025

Would help my team when we migrate soon :)
Thanks!

@Waschndolos
Copy link

Same here. Would be great to use it on Angular 19. Thanks for the effort!

@ghbob
Copy link
Contributor

ghbob commented Jan 8, 2025

@RobbieTheWagner sorry for the ping.
Could you have a look at this Angular 19 PR?
Thank you!

@RobbieTheWagner
Copy link
Member

This seems fine, but it seems like tests are not running for some reason 🤔

@bastienmoulia
Copy link
Contributor

This seems fine, but it seems like tests are not running for some reason 🤔

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

@RobbieTheWagner
Copy link
Member

@bastienmoulia there is usually something asking me to approve though, and I do not see that here.

@ghbob
Copy link
Contributor

ghbob commented Jan 14, 2025

Maybe an issue with the new merge box?

Old: https://github.com/shipshapecode/angular-shepherd/pull/2566?new_mergebox=false
New: https://github.com/shipshapecode/angular-shepherd/pull/2566?new_mergebox=true

old one says

1 workflow awaiting approval

@RobbieTheWagner
Copy link
Member

@ghbob ah, yes, thank you! @akhromets it looks like tests are failing

@akhromets
Copy link
Contributor Author

Hi @RobbieTheWagner , I'll have a look, thanks!

@akhromets
Copy link
Contributor Author

Hi @RobbieTheWagner , I’ve updated the tests.
Since components are standalone by default in Angular v19, I’ve explicitly marked them as standalone in the component decorators to avoid any confusion. I also replaced declarations with imports in the TestBed.configureTestingModule section.

@RobbieTheWagner RobbieTheWagner merged commit 24f498d into shipshapecode:main Jan 21, 2025
2 checks passed
@RobbieTheWagner
Copy link
Member

Thanks @akhromets!

@github-actions github-actions bot mentioned this pull request Nov 18, 2024
@akhromets akhromets deleted the bump-angular-version-to-19 branch January 21, 2025 16:05
@ghbob
Copy link
Contributor

ghbob commented Jan 27, 2025

@RobbieTheWagner will this be released as v19? thanks.

@RobbieTheWagner
Copy link
Member

@ghbob yes, this has now been released! I also updated Shepherd to 14.x which required messing with some TS stuff, so let me know if you all run into any issues.

@ghbob
Copy link
Contributor

ghbob commented Jan 28, 2025

Thank you!

In case anyone else didn't see this:
With Shepherd 14+ the license has changed: https://github.com/shipshapecode/shepherd?tab=License-1-ov-file

@RobbieTheWagner
Copy link
Member

Thanks for the callout @ghbob. We did update the license, but you only need to pay if you are running a commercial product, so hopefully it is not too restrictive for folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants