Skip to content

fix pivtool generate key touch policy #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix pivtool generate key touch policy #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/cosign/cli/pivcli/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,12 @@ func GenerateKeyCmd(ctx context.Context, managementKey string, randomKey bool, s
return flag.ErrHelp
}

pinPolicy := pivkey.PINPolicyForName(pinPolicyArg, *slot)
pinPolicy := pivkey.PINPolicyForName(strings.ToLower(pinPolicyArg), *slot)
if pinPolicy < 0 {
return flag.ErrHelp
}

touchPolicy := pivkey.TouchPolicyForName(pinPolicyArg, *slot)
touchPolicy := pivkey.TouchPolicyForName(strings.ToLower(touchPolicyArg), *slot)
if touchPolicy < 0 {
return flag.ErrHelp
}
Expand Down
2 changes: 0 additions & 2 deletions cmd/cosign/cli/pkcs11cli/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ func GetKeysInfo(_ context.Context, modulePath string, slotID uint, pin string)
}

func ListTokensCmd(ctx context.Context, modulePath string) error {

tokens, err := GetTokens(ctx, modulePath)
if err != nil {
return err
Expand All @@ -223,7 +222,6 @@ func ListTokensCmd(ctx context.Context, modulePath string) error {
}

func ListKeysUrisCmd(ctx context.Context, modulePath string, slotID uint, pin string) error {

keysInfo, err := GetKeysInfo(ctx, modulePath, slotID, pin)
if err != nil {
return err
Expand Down