-
Notifications
You must be signed in to change notification settings - Fork 582
feat: allow to verify-blob from urls #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
I would consider the security impacts here and consider using rekor instead (gather the signaturess by look up using digest). If someone compromises github.com/caarlos0 then they can dupe users into accepting a compromised container / blob and its respective pub key and signature etc with no open transparency for others to monitor. This was the driver for making rekor, as too many folks were storing artifacts and signatures alongside each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would like to just hold for a bit while we discuss this over.
There are no issues here IMO, I think you're misunderstanding the patch based on the example in the commit message. This would work with the transparency log if the experimental variable is set. @lukehinds could you explain the actual threat you're worried about in more detail? I don't think this introduces anything new or makes anything worse. This command would be run before a rekor-cli lookup, or use the built in transparency support if that's desired/important. |
You're right, did not articulate my comment to well, there is no new attack. For me it's a bit more about encouraging users into good habits to utilize rekor for public transparency (and detect key compromise etc). But I can see how this patch is a layer above that and its contingent upon cosign_experimental being set.
I might be misunderstanding verify-blob here, is this not to verify the blog signing, if so I would have thought you would want to check its in the tlog first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toggle off hold after speaking with Dan.
A minor quality of life improvement, allowing the blob and signature to come from a url as well, so we can, for instance:
previous behaviors (from file and base64 string) still work as before.