chore(ci): test on node v16

[SimenB]

No description provided.

[github-actions]

Thanks for opening this pull request! Each pull request require an update in the CHANGELOG. Please update it based on your changes.

[SimenB]

Oh wow, our tests make node abort 🙈

/cc @sam-github @siimon @zbjornson

I guess we should try to add this module to CITGM after we figure out what's wrong

[zbjornson]

node[1757]: ../src/env-inl.h:1052:void node::Environment::AddCleanupHook(node::Environment::CleanupCallback, void*): Assertion `(insertion_info.second) == (true)' failed.
 1: 0xb12b00 node::Abort() [node]
 2: 0xb12b7e  [node]
 3: 0xb7a58c  [node]
 4: 0xd5f70b  [node]
 5: 0xd60bac  [node]
 6: 0xd61226 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 7: 0x160c579  [node]
Aborted (core dumped)

Not particularly helpful. I can try to take a look later this week/weekend.

[analytik]

I got the same error when experimenting with a fix for #435 ... currently looking for a quickfix, even if not elegant.

EDIT: this happens when you try to call perf_hooks.performance.measure(someValue) several times with the same someValue it seems, at least for 'gc'.

EDIT 2: see correction below, the bug is on a (new perf_hooks.PerformanceObserver(...)).observe(...)

[SimenB]

@analytik do you have a minimal reproduction? I tried this and it seems to work?

const { performance } = require("perf_hooks");

for (let i = 0; i < 10; i++) {
  performance.measure("gc");
}

[analytik]

I think I got it - see my fresh bug report in node.js

EDIT: I misspoke, not .measure(), but .observe() for a new perf_hooks.PerformanceObserver instance

[SimenB]

16.1.0 released with a fix

[SimenB]

16.1.0 not added here yet, so 16.x does not work

[analytik]

Well, at least I can confirm that on Windows, 16.1.0 passes all tests and 16.0.0 crashes.

[SimenB]

Yeah, CI passes when I force it to be 16.1 👍