Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Super Dev Mode using GWT > 2.5.0 #56

Merged
merged 1 commit into from
May 12, 2014
Merged

added support for Super Dev Mode using GWT > 2.5.0 #56

merged 1 commit into from
May 12, 2014

Conversation

jwueller
Copy link
Contributor

Super Dev Mode works with GWT > 2.5.0, but only 2.5.0 was allowed. A more generalized version check is used to ensure compatibility now and in future versions.

@jwueller
Copy link
Contributor Author

Correction: This is for GWT > 2.5.x.

Also fixes potential issue with multi-digit version components.

daviddawson pushed a commit that referenced this pull request May 12, 2014
added support for Super Dev Mode using GWT > 2.5.0
@daviddawson daviddawson merged commit 0df5c5f into simplicityitself:master May 12, 2014
@jwueller jwueller deleted the superdevmode-compat branch May 12, 2014 13:43
@confile
Copy link

confile commented May 12, 2014

@jwueller What does this fix do? I use grails-gwt with GWT 2.6.0 and super dev mode all the time with no problems

@jwueller
Copy link
Contributor Author

@confile addGwtCoreToDependencies() previously didn't add these dependencies for GWT > 2.5.x:

addDependency("com.google.gwt", "gwt-codeserver", version)
addDependency("org.json", "json", "20090211")

because of this version check:

if (version.startsWith("2.5")) {

causing the availability check for com.google.gwt.dev.codeserver.CodeServer to fail. This, in turn, triggered the following false-negative:

Super Dev Mode only support in GWT 2.5.0 version

effectively breaking Super Dev Mode for everyone using GWT 2.6.0 or similar by refusing to start.


As to why you are not experiencing this problem: This issue would not occur if you manually added the codeserver to your classpath. Is that possibly what you are using in your setup?

@confile
Copy link

confile commented May 12, 2014

I use an external GWT project which uses a Grails project as host project. So yes you are right I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants