-
-
Notifications
You must be signed in to change notification settings - Fork 961
General improvements to the tests and CI Environment #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements to the tests and CI Environment #1461
Conversation
With the latest commit (9fa1d1c) I copy-and-pasted (and ported to Typescript) https://github.com/lukechilds/create-test-server . For tests regarding HTTPS Tests are now much faster and shouldn't timeout on slower systems. How is this related to this PR?Looking at https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=osx1014/935/testReport/junit/(root)/citgm/got_v11_6_1/ (macOS 10.14) the tests timed out, as you can see there are some tests which took up to a minute and a half to run. It could be due to the "different" openssl present on macOS (might be a slower release), or to the fact that the hardware beneath the OS is a Mac mini (a common setup for a macOS server). |
It seems that Tavis CI Ubuntu Focal VM does not resolve IPv6 hostnames. I disabled that test for Focal on Travis CI. process.env.TRAVIS_DIST !== 'focal' |
|
Yes, we are going have less platforms to run the tests, but that shouldn't be a problem.
I opened this PR to make the I would like to have this PR on Issue pointed out by you, such as:
Are going to be addressed in the new PRs. Let me know what do you think about this. Of course the incredibly-overdue PR #1272 is going to be closed in favor of the newer one. |
I don't really see the point of testing on so many Linux combinations. It's unlikely to make a difference but will make builds slower. This is especially true for macOS. I think we should limit it to latest macOS and Windows, and also Ubuntu Bionic (18.04) and Ubuntu Focal (20.04). |
Merging this as there was a request to get it merged fast. But please address the feedback given here in the follow-up PR. |
Sure, I'm already preparing it, a draft is coming soon. |
As can be seen here: https://ci.nodejs.org/job/citgm-smoker-nobuild/935/ the fact that the Got tests pass on "an ubuntu release" doesn't mean that it works everywhere.
I added some OS: Ubuntu Trusty (14.04), Ubuntu Xenial (16.04), Ubuntu Bionic (18.04), Ubuntu Focal (20.04), Windows 1809 (newer versions are not supported), macOS 10.14, macOS 10.15.
Whenever we decide to switch to Github Actions these are the available OS.