Skip to content

Fix failure of test_kubernetes_context_failover #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Apr 30, 2025

Resolve #5437

Test broken after #5362 because the display logic changed.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Relevant individual tests: /smoke-test -- --kubernetes -k test_kubernetes_context_failover (CI)

@zpoint
Copy link
Collaborator Author

zpoint commented Apr 30, 2025

/smoke-test --kubernetes -k test_kubernetes_context_failover

@zpoint zpoint requested a review from SeungjinYang April 30, 2025 08:34
@zpoint
Copy link
Collaborator Author

zpoint commented May 1, 2025

/smoke-test --kubernetes -k test_kubernetes_context_failover

@zpoint zpoint requested review from cg505 and SeungjinYang May 1, 2025 02:59
Copy link
Collaborator

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, seems good!

@zpoint zpoint merged commit 6b1b459 into skypilot-org:master May 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes test test_kubernetes_context_failover fail on master
3 participants