[Nebius] Add support config file and remove hardcode #5463
+85
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nebius project ID file support has been removed in favor of configuration in `~/.sky/config.yaml`, which now includes `project_id` and `fabric` options. Enhancements include streamlined GPU cluster creation and clearer documentation for Nebius configurations.
cg505
reviewed
May 1, 2025
|
|
||
| .. code-block:: shell | ||
| **Optional**: You can specify a preferable project ID and fabric in `~/.sky/config.yaml` |
There was a problem hiding this comment.
Question about "preferable" - does this mean that the project id / fabric can be ignored in some cases, or is it always respected?
| Optional: GPU cluster disabled if not specified | ||
|
|
||
|
|
||
| The configuration can be specified in region-specific sections. |
There was a problem hiding this comment.
Suggested change
| The configuration can be specified in region-specific sections. | |
| The configuration must be specified in region-specific sections. |
Comment on lines
+550
to
+556
| .. code-block:: yaml | ||
|
|
||
| echo $NEBIUS_PROJECT_ID > ~/.nebius/NEBIUS_PROJECT_ID.txt | ||
| # ~/.sky/config.yaml | ||
| nebius: | ||
| eu-north1: | ||
| project_id: project-e00xxxxxxxxxxxx | ||
| fabric: fabric-2 |
There was a problem hiding this comment.
I think this should be moved to cloud-setup/cloud-permissions/nebius.rst. We can just have a link in the "Optional:" part to that page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nebius project ID file support has been removed in favor of configuration in
~/.sky/config.yaml, which now includesproject_idandfabricoptions. Enhancements include streamlined GPU cluster creation and clearer documentation for Nebius configurations.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)