Skip to content

[Nebius] Conditionally mount AWS credential files for Nebius profile #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

SalikovAlex
Copy link
Contributor

Previously, AWS credential files were always mounted, even when unnecessary. This change ensures they are only mounted if the Nebius profile is referenced in the AWS credentials and config files. This reduces redundancy and improves configuration flexibility.

Fixing: #5338

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh

Previously, AWS credential files were always mounted, even when unnecessary. This change ensures they are only mounted if the Nebius profile is referenced in the AWS credentials and config files. This reduces redundancy and improves configuration flexibility.
Copy link
Collaborator

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SalikovAlex! I think this looks good.

@cg505
Copy link
Collaborator

cg505 commented May 1, 2025

/smoke-test -k test_basic

@cg505 cg505 linked an issue May 1, 2025 that may be closed by this pull request
@cg505 cg505 merged commit 7bfd878 into skypilot-org:master May 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nebius] ~/.aws/config and ~/.aws/credentials uploaded unconditionally
2 participants