Skip to content

Add a CompatHelper action? #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkarrasch opened this issue Mar 20, 2023 · 5 comments
Closed

Add a CompatHelper action? #43

dkarrasch opened this issue Mar 20, 2023 · 5 comments

Comments

@dkarrasch
Copy link
Contributor

I noticed JOLI.jl has a couple of outdated dependencies, for instance Flux.jl which is restricted to v0.12, but whose current version is v0.13.14. Perhaps it would make sense to add a CompatHelper workflow, to receive Project.toml updates via PRs, in which you can check if such an update is acceptable or not. See https://github.com/JuliaRegistries/CompatHelper.jl for more info.

@mloubout
Copy link
Member

Flux.jl isn't a dependency, it's only a conditional one for testing but is not part of JOLI.jl (only used in rrule test).

ComparHelper is already setup
https://github.com/slimgroup/JOLI.jl/blob/master/.github/workflows/CompatHelper.yml

And all dependencies are up to date.

@dkarrasch
Copy link
Contributor Author

Hm, should have checked before. Okay, but then why isn't NFFT.jl and Flux.jl up to date? I was working on a PR in Julia LinearAlgebra, which requires updates to very fundamental packages. The cap on Flux inhibits updating ArrayInterface.jl, which has updates that make it run smoothly both before and after that PR.

@dkarrasch
Copy link
Contributor Author

Perhaps updating the CompatHelper script to https://github.com/JuliaRegistries/CompatHelper.jl/blob/master/.github/workflows/CompatHelper.yml would help with the different dependency types.

@mloubout
Copy link
Member

NFFT.jl newer versions have breaking changes, is on my list to fix.

For Flux there isn't really anything preventing upgrading it will check your link to make sure extra get caught as well.

Thanks for pointing it out

mloubout added a commit that referenced this issue Mar 20, 2023
@mloubout
Copy link
Member

Oh dang, it looks like CompatHelper stopped running due to inactivity, I'll try to keep an eye on it in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants