fix the example scripts and isadjoint #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Examples are small so maybe add them to CI, GTG. |
|
Also fix the |
mloubout
reviewed
Jan 31, 2022
.github/workflows/ci-example.yaml
Outdated
| - name: Build JOLI | ||
| uses: julia-actions/julia-buildpkg@latest | ||
|
|
||
| - name: Run examples |
There was a problem hiding this comment.
that's overkill for this small, just add that one step to the standard CI.
ziyiyin97
changed the title
mloubout
reviewed
Jan 31, 2022
.github/workflows/ci-joli.yaml
Outdated
| working-directory: examples | ||
| run: | | ||
| julia -e 'using Pkg; Pkg.add("JOLI")' | ||
| julia -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd()))' |
There was a problem hiding this comment.
That's adding JOLI twice, once in add and once in dev. JOLi already instantiated an simple julia --project should be enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isadjointfor real domain and complex range operators