use reverse to replace deprecated flipdim
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joExtend already work for multidimensional arrays, that's what |
mloubout
reviewed
Jul 16, 2022
| @@ -187,3 +187,9 @@ function joExtend(n::Integer,pad_type::Symbol; | |||
| return nothing | |||
| end | |||
|
|
|||
| function joExtend(n::NTuple{N, Integer},pad_type::Symbol; | |||
There was a problem hiding this comment.
That's not the convention in JOLI, the convention is joXXX(n1, n2, n3 ....) no a tuple.
There was a problem hiding this comment.
Thanks. Vararg{Integer, N} would only be OK if that is the last argument. However, there is a pad_type after that. Any suggestion?
ziyiyin97
changed the title
reverse to replace deprecated flipdim
|
Update project.toml |
|
Is there a hold up here I can help with? I ran into this error for the second time in the last few months. |
|
Project.toml update for new release |
|
And if it creates a bug then there should be a test associated with it |
mloubout
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flipdimalready deprecated so changed it toreverse