Expose more kinds of text edit widgets to AccessKit #7823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
force-pushed
the
accessible-input-type
branch
3 times, most recently
from
ec8fa7d to
5ece1b3
Compare
DataTriny
force-pushed
the
accessible-input-type
branch
from
5ece1b3 to
52abaee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2895
Which value is allowed in a text input should be communicated to assistive technologies. In AccessKit this means setting different roles when possible, instead of the generic
Role::TextInput. I chose to not introduce a new accessibility property for this:LineEditwidgets, and a multiline property would only be valid onTextEdit,TextInputitem from the AccessKit backend anyway to expose text runs and I now believe that doing some compiler magic is going to be very tricky if possible at all.Fixes the Spinbox widget while at it.