Feat/cli 22w39 initial prototype #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: suppress unrequired INSTALL_REQUIRES should not be builtins validate and datetime do not appear to be required
support pep517 and pep518
test: 1st test example
examples pysmartdatamodels_cli datamodels_subject dataModel.PointOfInteraction pysmartdatamodels_cli --help
fix: validate_data_model_schema, suppress print fix: validate_data_model_schema return native object ie dict refactor: black format
when installed --editiable it is file reachable when instaled without --editable file is not available bring into package module folder and and set as a required
chore: add to .gitignore builds and eggs Incorrect indentation in section [options.package_data] add a default pytest.ini until full PEP621 (only pyproject.toml)
|
Hi, thanks for the contribution. The changes look go to me. |
wistefan
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Proposal - (WIP for review/suggestions/discussion)
Whilst I am integrating aspects of the SmartDataModels into some of our applications, I see there being great benefit to enhancing the work in various scripts particularly
pysmartdatamodels. This PR is there for discussion and suggestions. Possibly thepysmartdatamodelsshould be its own repo withinSmart-data-modelsrather than a folder within this repodata-modelsDemonstration of functionality can be found in https://colab.research.google.com/drive/1D8jZ6-sOGCksAtJ6NUHv9yk6ONvjKJBc?usp=sharing
pysmartdatamodel_cli --help✅installing this with
poetryusingpoetry add ......works now as expected , including in--editablemode✅installing this with
pip install .......breaking changes
the pysmartdatamodels.py is turned into a module with all the functions copied across into
pysmartdatamodels/commands.py. Only minor alterations are the relocation of theofficial_list_data_models.jsoninto a folderpysmartdatamodel/model-assets/and the change ofdata-models/pysmartdatamodels/pysmartdatamodels.py
Line 326 in cb958f2
validate_data_model_schema(schemaUrl)tovalidate_data_model_schema(schema_url)for some reason the CLI auto generator does not want to recognizeschemaUrl