Support list patterns #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juusom
commented
Apr 3, 2020
lassizci
reviewed
Apr 6, 2020
lassizci
reviewed
Apr 6, 2020
juusom
force-pushed
the
list-pattern-input
branch
from
b0c3bec to
5f8023b
Compare
juusom
force-pushed
the
list-pattern-input
branch
5 times, most recently
from
e6b7762 to
3b772db
Compare
added 2 commits
April 7, 2020 14:53
juusom
force-pushed
the
list-pattern-input
branch
2 times, most recently
from
a26004a to
12e270c
Compare
…ecution-engine remove ruby pipeline dependency
…ecution-engine fix bump version
* Fix: do not rely on redis.client anymore * Test: redo specs with 'real' Redis mocking * Refactor: cleanup plugin (internals) Co-authored-by: Ry Biesemeyer <[email protected]>
Redis doesn't wrap all of the errors e.g. (retriable) IOError might be raised from an IO write (logstash-plugins#88). With the refactored error handling we make sure these are logged and retried instead of causing pipeline crashes. Also not all specs from the suite were run on the CI, as some are tagged with redis. These require a real Redis server, no reason not to run them against CI as well.
juusom
force-pushed
the
list-pattern-input
branch
2 times, most recently
from
a4fb749 to
40c52e9
Compare
|
This branch seems to hold the most up to date stuff from master (now main) even today. |
|
Well hello! Note btw that there's still an upstream PR open: logstash-plugins#81 . You might want to subscribe to it in case anyone ever picks it up 😅 |
|
Hi, any plans to add logstash-plugins#81 to master in the near future ? Its been a while waiting for merge now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP