Make FFI callbacks thread safe #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.1: Backport fix for GH-12512: JIT Assertion `info & (1 << type)' failed (#12660)
* PHP-8.2: Backport fix for GH-12512: JIT Assertion `info & (1 << type)' failed (#12660)
* PHP-8.3: Backport fix for GH-12512: JIT Assertion `info & (1 << type)' failed (#12660)
…2650) zend: introducing ZEND_ELEMENT_COUNT for struct's dynamic and flexible arrays. It is mostly for ubsan and helping array bound checking.
…e descriptor array Closes GH-12658.
* PHP-8.2: Fix GH-12655: proc_open() does not take into account references in the descriptor array
* PHP-8.3: Fix GH-12655: proc_open() does not take into account references in the descriptor array
* PHP-8.1: NEWS fix GH-12661 (Inconsistency in ZipArchive::addGlob remove_path Option Behavior)
* PHP-8.2: NEWS NEWS fix GH-12661 (Inconsistency in ZipArchive::addGlob remove_path Option Behavior)
* PHP-8.3: NEWS NEWS fix GH-12661 (Inconsistency in ZipArchive::addGlob remove_path Option Behavior)
* PHP-8.3: NEWS
* PHP-8.3: zip extension is 1.22.3
MSAN is slow in particular, leading to potentially higher deviations.
* PHP-8.2: [skip ci] Further increase allowable atime deviation
* PHP-8.3: [skip ci] Further increase allowable atime deviation
* Improve JIT config in fuzzer SAPI * Fix * Fix * Update
Closes GH-12425
gen_stub.php references classes inside namespaces relatively
Now that we have class aliases (DOMNode -> DOM\Node), it has become important to add them to the class map so that it will be possible to generate class synopses for them.
…ct as array (#12799)
* PHP-8.2: Align error messages between normal VM and JIT for RW when using object as array (#12799)
* PHP-8.3: Align error messages between normal VM and JIT for RW when using object as array (#12799)
Closes GH-12403
Some jobs on GA apparently consume a lot of CPU resources, possibly hindering communication between master and runner. This only seems to happen on Linux+ASAN and macOS. For these jobs, keep one core idle. Closes GH-12742
* PHP-8.2: Reduce parallelism on frequently crashing jobs
* PHP-8.3: Reduce parallelism on frequently crashing jobs
For acbdfd2.
…ong undefined array key warning (#12817) * Fixed GH-12812: Integer string in variable used as offset produces wrong undefined array key warning * Fixed register names
* PHP-8.2: Fixed GH-12812: Integer string in variable used as offset produces wrong undefined array key warning (#12817)
* PHP-8.3: Fixed GH-12812: Integer string in variable used as offset produces wrong undefined array key warning (#12817)
* Fast path for when there is nothing to trim in mb_trim * Make mb_trim decide between linear search vs hash table lookup Using empirical experiments I noticed that on my i7-4790 the hash table approach becomes faster once we have more than 4 code points in the trim characters, when evaluated on the worst case. This patch changes the logic so that a hash table is used for a large number of trim characters, and linear search when the number of trim characters is <= 4.
This is _not_ exploitable right now because libxml guarantees right now a maximum string length of 1M bytes. But if that limit were to ever change this could overflow in the future leading to exploits. Again, not exploitable right now, but just making it more future-proof.
* PHP-8.2: Fixed GH-8251: Narrowing occurred during type inference of ZEND_FETCH_DIM_W
* PHP-8.3: Fixed GH-8251: Narrowing occurred during type inference of ZEND_FETCH_DIM_W
* PHP-8.2: [skip ci] Skip resource intensive tidy test on GA
* PHP-8.3: [skip ci] Skip resource intensive tidy test on GA
… one add zend_ffi_wait_request_barrier helper function add callback_in_progress flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes FFI callbacks work, regardless of the thread they are invoked from