Skip to content

Do not dismiss failures prior to serialization #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BenFradet opened this issue Jun 29, 2017 · 2 comments
Closed

Do not dismiss failures prior to serialization #101

BenFradet opened this issue Jun 29, 2017 · 2 comments
Assignees
@BenFradet
Labels
bug
Milestone
Version 0.5.0

Comments

@BenFradet
Copy link
Contributor

No description provided.

@BenFradet BenFradet added this to the Version 0.5.0 milestone Jun 29, 2017
@BenFradet BenFradet self-assigned this Jun 29, 2017
BenFradet added a commit that referenced this issue Jun 29, 2017
@BenFradet
Do not dismiss failures prior to serialization (closes #101)
42f6a29
@alexanderdean
Copy link
Member

Thanks @BenFradet. Do we have a sense yet of what kinds of scenarios could lead to events failing pre-serialization?

@BenFradet
Copy link
Contributor Author

Haven't looked into that yet but when inspecting the logs I noticed a few times that groups of messages seem to reach this https://github.com/snowplow/kinesis-s3/blob/master/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis/s3/S3Emitter.scala#L121 but are never heard of again that's what made me look into this in the first place.

BenFradet added a commit that referenced this issue Jun 30, 2017
@BenFradet
Do not dismiss failures prior to serialization (closes #101)
7201342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenFradet BenFradet

Labels
bug
Projects
None yet
Milestone
Version 0.5.0
Development

No branches or pull requests
2 participants
@alexanderdean @BenFradet