Skip to content

Refactor to change purpose of the S3Emitter class #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aldemirenes opened this issue Aug 13, 2017 · 0 comments
Closed

Refactor to change purpose of the S3Emitter class #110

aldemirenes opened this issue Aug 13, 2017 · 0 comments
Assignees
Milestone

Comments

@aldemirenes
Copy link
Contributor

Right now, all methods for sending data to S3 are in the S3Emitter class which is only used with Kinesis. It will be good if we refactor this class to make that it can be used with other tools such as NSQ too and create new KinesisS3Emitter class for sending data to S3 from Kinesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant