Skip to content

Allow override of kinesis and s3 endpoints in configuration #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arihantsurana opened this issue Jun 3, 2018 · 0 comments
Closed

Allow override of kinesis and s3 endpoints in configuration #131

arihantsurana opened this issue Jun 3, 2018 · 0 comments
Milestone
Version 0.7.0

Comments

@arihantsurana
Copy link
Contributor

add the endpoint override as done in the PR - #3777

I think I have isolated all the pieces requiring override:

snowplow-s3-loader/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis/s3/SinkApp.scala

Lines 147 to 150 in bdb6ca5

val s3Endpoint = s3Region match {
case "us-east-1" => "https://s3.amazonaws.com"
case _ => s"https://s3-$s3Region.amazonaws.com"
}

snowplow-s3-loader/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis/s3/SinkApp.scala

Line 140 in bdb6ca5

val kEndpoint = s"https://kinesis.${kinesisSinkRegion}.amazonaws.com"

snowplow-s3-loader/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis/s3/SinkApp.scala

Line 94 in bdb6ca5

val kinesisSinkEndpoint = s"https://kinesis.${kinesisSinkRegion}.amazonaws.com"

I'll add the PR with changes next.
arihantsurana added a commit to arihantsurana/snowplow-s3-loader that referenced this issue Jun 21, 2018
@arihantsurana
issue-131: override kinesis and s3 endpoints in configuration file
8d54b86 
Pull request to remedy the issue snowplow#131

This change allows addition of override on kinesis and s3 endpoints in the configuration files. Allowing use of localstack.
@arihantsurana arihantsurana mentioned this issue Jun 21, 2018
Merged
@BenFradet BenFradet changed the title Storage Kinesis-s3: Allow override of kinesis and s3 endpoints in configuration file Allow override of kinesis and s3 endpoints in configuration file Jun 21, 2018
@BenFradet BenFradet changed the title Allow override of kinesis and s3 endpoints in configuration file Allow override of kinesis and s3 endpoints in configuration Jun 21, 2018
@BenFradet BenFradet added this to the Version 0.7.0 milestone Jun 21, 2018
peel pushed a commit that referenced this issue Feb 24, 2020
@arihantsurana @peel
Allow override of kinesis and s3 endpoints in configuration (closes #131
0a45645 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.7.0
Development

No branches or pull requests
2 participants
@BenFradet @arihantsurana