Skip to content

Harmonize module structure #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chuwy opened this issue Apr 29, 2021 · 0 comments
Closed

Harmonize module structure #210

chuwy opened this issue Apr 29, 2021 · 0 comments
Assignees
Milestone

Comments

@chuwy
Copy link
Contributor

chuwy commented Apr 29, 2021

This is an umbrella ticket for work I've done on restructuring the code of S3 Loader and does not bring any user-facing changes. Main goals were:

  1. Extract everything related to kinesis-connector into its own connector module to make it easier to factor out later
  2. Remove several unused entities from previous versions such as Thrift decoders
  3. Harmonize configuration: remove stringly-typed properties, use circe codecs, move everything configuration-related into one module, add a test spec, provide better error messages
  4. Merge KinesisS3Emitter and S3Emitter - they're the same thing
@chuwy chuwy added this to the Version 1.1.0 milestone Apr 29, 2021
@chuwy chuwy self-assigned this Apr 29, 2021
chuwy added a commit that referenced this issue Apr 29, 2021
chuwy added a commit that referenced this issue Apr 29, 2021
chuwy added a commit that referenced this issue May 24, 2021
@chuwy chuwy closed this as completed in e377c5b Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant