Skip to content

Fix premature shutdown of HTTP connection pool #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oguzhanunlu opened this issue Oct 29, 2021 · 0 comments
Closed

Fix premature shutdown of HTTP connection pool #231

oguzhanunlu opened this issue Oct 29, 2021 · 0 comments

Comments

@oguzhanunlu
Copy link
Member

oguzhanunlu commented Oct 29, 2021

S3 Loader 2.0.0 throws java.lang.IllegalStateException: Connection pool shut down after a RecordProcessor hits end of a shard.

Behind the scenes, reaching the end of a shard causes shutdown of its' RecordProcessor which in turn shutdowns the emitter of that record processor. Shutting down the emitter calls client.shutdown where client is shared across all emitters. Given that an S3 Client maintains its own connection pool, shutting down the single S3 client shutdowns its' connection pool as well.

We should not be shutting down the S3 client at KinesisS3Emitter.shutdown which is a premature shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant