Skip to content

PartitionFormat not working as intented #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ollikaven opened this issue Dec 20, 2021 · 1 comment
Closed

PartitionFormat not working as intented #247

ollikaven opened this issue Dec 20, 2021 · 1 comment

Comments

@ollikaven
Copy link

Version: 2.1.2

For SELF_DESCRIBING events I'm using the example configuration for partitionFormat (except after last slash).
"partitionFormat": "{vendor}.{name}/model={model}/dt={yy}-{mm}-{dd}",
I would assume the first part of the prefix would be e.g.:
com.snowplowanalytics.snowplow.badrows.schema_violations/.

However, this config will produce prefix. The last part timestamp of sort?
com.snowplowanalytics.snowplow.badrows.705000000AM72

Changing {name} to {schema} works as expected:
"partitionFormat": "{vendor}.{schema}/model={model}/dt={yy}-{mm}-{dd}",
This will create prefix:
com.snowplowanalytics.snowplow.badrows.schema_violations/.

Maybe this line has something to do with this behaviour?
https://github.com/snowplow/snowplow-s3-loader/blob/master/src/main/scala/com/snowplowanalytics/s3/loader/connector/KinesisS3Emitter.scala#L245

@istreeter
Copy link
Contributor

Thanks @ollikaven this is definitely an error!

I think it is an error in the example configuration file, rather than error in the code, i.e. the intended syntax was {vendor}.{schema} instead of {vendor}.{name}.

I suggest I change it so that both {schema} and {name} are both valid and both do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants