Skip to content

Remove curly braces from transformed directory pattern #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

arihantsurana
Copy link
Contributor

The directory pattern currently allows DateTime pattern in the curly braces . to be resolved to actual date. This PR removes the braces used to indicate a pattern from the final directory.

Updated unit tests to reflect the correct behaviour.

@snowplowcla
Copy link

@arihantsurana has signed the Software Grant and Corporate Contributor License Agreement

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try publishing an rc later today

@BenFradet BenFradet merged commit 3ad0d10 into snowplow:develop Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants